kgabryje opened a new pull request, #26963: URL: https://github.com/apache/superset/pull/26963
### SUMMARY PR #26453 introduced important accessibility upgrades, but broke displaying table totals in sticky mode. Since the totals being always visible (sticky) is a key feature of the table chart, I think we should revert the accessibility PR and reopen it once the bug is fixed. CC @ncar285 @eschutho ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before the revert: https://github.com/apache/superset/assets/15073128/20cf0f7a-0601-4ff5-b172-4cf24ea04e51 After: https://github.com/apache/superset/assets/15073128/e79efd86-7825-4e33-8239-a81e2bc0a723 ### TESTING INSTRUCTIONS 1. Create a table chart with enough rows to enable scrolling 2. Check "Show totals" 3. Verify that totals row is sticky ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
