kgabryje opened a new pull request, #26964: URL: https://github.com/apache/superset/pull/26964
### SUMMARY !!! THIS PR IS DEPENDENT ON #26963 !!! Only commit https://github.com/apache/superset/commit/32073e38fd4bc57519ad8cba0ed0aea8b32006e8 is relevant to this PR. In the table chart, when scrollbar is set to be always visible (on macOS Sonoma: System settings -> Appearance -> Show scroll bars -> Always), it takes some space in table's body and pushes its content to the left. That causes the totals and headers to appear misaligned with the body. This problem doesn't occur on default scrollbar settings in macOS - in this case when the scrollbar appears, it is displayed over the scroll container and doesn't cause a layout shift. `scrollbar-gutter: stable` (https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-gutter) css declaration reserves the space required for the scrollbar to appear and not cause a layout shift and it works well for both scrollbar system settings (though in the auto mode we waste a few pixels). CC @vasu-ram ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: <img width="1051" alt="image" src="https://github.com/apache/superset/assets/15073128/372883ff-67a6-43ec-b85a-efe0b2b3d7c7";> After: <img width="1728" alt="image" src="https://github.com/apache/superset/assets/15073128/bd4aad36-113e-4a73-9a7f-e92e7a36073d";> ### TESTING INSTRUCTIONS 1. Create a table chart with at least ~5-6 columns and enough rows to trigger overflow 2. Check "Show totals" 3. If you're using macOS - set the scrollbar to be always visible (System settings -> Appearance -> Show scroll bars -> Always) 4. Verify that values in table's body are aligned with headers and totals 5. Set the scrollbar to the default behaviour (System settings -> Appearance -> Show scroll bars -> Automatically based on mouse or trackpad) 6. Verify that everything's still aligned ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: fixes #26761 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
