villebro commented on issue #14619: URL: https://github.com/apache/superset/issues/14619#issuecomment-1922058617
> IMO it seems like a bug, since Sentinel is otherwise supported with Superset. It took a bit of digging for me to realize that plain redis is hard-coded in the config for async queries @xenago oh yeah, I see what you mean. Fixing this should be straight forward. would you mind taking a stab at this? I assume we could just replace `GLOBAL_ASYNC_QUERIES_REDIS_CONFIG` with an instance of whichever backend the deployment wishes to use (`redis.Redis` for most cases). @rusackas @michael-s-molina I think this is one of those opportunistic breaking changes I think we should consider including in the scope of 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
