mistercrunch commented on code in PR #26923: URL: https://github.com/apache/superset/pull/26923#discussion_r1475082004
########## docs/README.md: ########## @@ -16,4 +16,7 @@ KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -This is the public documentation site for Superset, built using [Docusaurus 2](https://docusaurus.io/). See [CONTRIBUTING.md](../CONTRIBUTING.md#documentation) for documentation on contributing to documentation. +This is the public documentation site for Superset, built using Review Comment: Actually I don't think i touched this did I? Personally I like line breaks and happily will get into a tabs-vs-space religious debate over it :) Main point is around "diffing". If you have a long paragraph and fix a typo, you're in the `git blame` for that whole line, and diffs will be much more verbose than needed. I vote for line breaks soft at 80-90, hard at 100, and across file most file types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
