dnskr opened a new pull request, #27005: URL: https://github.com/apache/superset/pull/27005
### SUMMARY There is an inconsistency between the chart `appVersion` value and default image tag, that was introduced in PR https://github.com/apache/superset/pull/26923. File `Chart.yaml` declares `3.1.0` as default supported version to be deployed by the chart: ```yaml ... apiVersion: v2 appVersion: "3.1.0" description: Apache Superset is a modern, enterprise-ready business intelligence web application name: superset ... ``` It's also visible by the following command: ```shell $ helm search repo superset NAME CHART VERSION APP VERSION DESCRIPTION superset/superset 0.12.2 3.1.0 Apache Superset is a modern, enterprise-ready b... ``` However, the chart uses `latest` image tag that may change over time: ```shell $ helm show values superset/superset --jsonpath '{.image.tag}' latest ``` As far as I know, it's a good practice for Helm charts to set explicit value to `appVersion` and use it as default version to be deployed. For example, Airflow, ArgoCD and other Helm charts use this approach. **The PR partially reverts PR https://github.com/apache/superset/pull/26923!** ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
