betodealmeida commented on code in PR #27019:
URL: https://github.com/apache/superset/pull/27019#discussion_r1480460882
##########
superset/commands/report/alert.py:
##########
@@ -169,7 +169,12 @@ def _execute_query(self) -> pd.DataFrame:
logger.warning("A timeout occurred while executing the alert
query: %s", ex)
raise AlertQueryTimeout() from ex
except Exception as ex:
- raise AlertQueryError(message=str(ex)) from ex
+ logger.exception("An error occurred when running alert query")
Review Comment:
@mistercrunch I agree! `logger.exception` is different from `logger.error`
in that will log the full stack trace together with the error message, so we're
not losing any information here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
