justinpark commented on PR #26699:
URL: https://github.com/apache/superset/pull/26699#issuecomment-1933157824

   @yousoph Sorry for the late response. Here are my answers.
   
   > 1. When adding tabs to a dashboard, the drop area extends a bit too far, 
into the right panel
   
   Given that the tab (in the header) will occupy the whole row, including the 
right panel as shown in the following screenshot, it seems more logical for 
this highlight area to indicate its transition into a global header layout.
   
   ![Screenshot_2024-02-07_at_4_05_40 
PM](https://github.com/apache/superset/assets/1392866/743352b3-4ac4-4261-b1ad-d517a317202d)
   
   > 2. When adding a chart element, the dashboard header row is also 
highlighted as a possible drop area
   
   As discussed during our plans for further D&D improvements, I've earmarked 
this particular enhancement for @rtexelm's project. In the interim, this 
version will highlight in red (instead of the primary color) when you hover 
over the drop area, as shown in the following screenshot.
   
   
![chart_disabled_area](https://github.com/apache/superset/assets/1392866/ac44ad5c-6bf5-4e2d-b525-011a591092be)
   
   > 3. I managed to get an error when dragging a chart in between the header 
and the dashboard area somewhere, but I can't figure out how to repro it :(
   
   I tried to reproduce the same problem but cannot get the issue yet. please 
let me know if you find the problem again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to