mistercrunch commented on code in PR #27030:
URL: https://github.com/apache/superset/pull/27030#discussion_r1482275836
##########
superset-frontend/src/components/AlteredSliceTag/index.tsx:
##########
@@ -27,53 +26,84 @@ import { Tooltip } from 'src/components/Tooltip';
import ModalTrigger from '../ModalTrigger';
import TableView from '../TableView';
-const propTypes = {
- origFormData: PropTypes.object.isRequired,
- currentFormData: PropTypes.object.isRequired,
-};
+// Define interfaces for props and state
+interface FormData {
+ [key: string]: any; // Use a more specific type if possible for your form
data
Review Comment:
@geido it's still progress to get this through as is... wondering if for we
welcome this PR as is, and take on different smells knowing that overall this
is less smelly than what we had before (?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
