rusackas commented on PR #22183:
URL: https://github.com/apache/superset/pull/22183#issuecomment-1934521872
I'll try to ping some folks (e.g. @kgabryje ) about it who know the datamask
implications better than I do, but I see a couple things right away that I'm
curious about:
1) There's a typescript error that will need to be addressed which will
prevent merging.
2) I see there's a vector path hard-coded in here, which raises a few
questions:
* Can we import/use the path from one of our SVG files (filter icon) so
that it's always in sync if we change that?
* Is this the right icon to use to emit a cross-filter, or is there
something better (cc. @kasiazjc )
* This might be getting too fancy, but... can/should the icon/button be
togglable to emit/remove the crossfilter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
