betodealmeida opened a new pull request, #27053:
URL: https://github.com/apache/superset/pull/27053

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Prophet will log errors when optional dependencies are not installed:
   
   ```python
   try:
       import plotly.graph_objs as go
       from plotly.subplots import make_subplots
   except ImportError:
       logger.error('Importing plotly failed. Interactive plots will not work.')
   ```
   
   (It does something similar for `matplotlib`.)
   
   These calls to `logger.error` will pollute and trigger unnecessary alerts.
   
   This PR introduces a decorator `suppress_logging` that can be used in cases 
like this to suppress the logging:
   
   ```python
   with suppress_logging("prophet.plot", logging.CRITICAL):
       from prophet import Prophet
   ```
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ```python
   >>> import prophet
   Importing plotly failed. Interactive plots will not work.
   >>>
   ```
   
   ```python
   >>> from superset.utils.decorators import suppress_logging
   >>> import logging
   >>> with suppress_logging("prophet.plot", logging.CRITICAL):
   ...     import prophet
   ...
   >>>
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to