fengsi commented on code in PR #26663:
URL: https://github.com/apache/superset/pull/26663#discussion_r1485816877
##########
helm/superset/templates/secret-env.yaml:
##########
@@ -30,10 +30,17 @@ metadata:
type: Opaque
stringData:
REDIS_HOST: {{ tpl .Values.supersetNode.connections.redis_host . | quote }}
+ REDIS_USER: {{ .Values.supersetNode.connections.redis_user | quote }}
{{- if .Values.supersetNode.connections.redis_password }}
REDIS_PASSWORD: {{ .Values.supersetNode.connections.redis_password | quote
}}
{{- end }}
REDIS_PORT: {{ .Values.supersetNode.connections.redis_port | quote }}
+ REDIS_PROTO: {{ if .Values.supersetNode.connections.redis_ssl.enabled
}}"rediss"{{ else }}"redis"{{ end }}
Review Comment:
This has broken those w/o generating the default secret, which is a very
common use case to manage secrets separately (rather than relying on the Helm
chart).
This kind of backward compatibility should have been implemented somewhere
else, and it's not a good practice not to even document/mention this
feature/behavior change at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
