geido commented on PR #26202: URL: https://github.com/apache/superset/pull/26202#issuecomment-1952598965
I think it would be great if the input would catch this before submitting to the backend <img width="632" alt="Screenshot 2024-02-19 at 16 35 12" src="https://github.com/apache/superset/assets/60598000/4430bb16-b5b1-4157-b177-daf3c7f4dd4e";> We should probably erase the value when setting the "Not null" option <img width="624" alt="Screenshot 2024-02-19 at 16 38 43" src="https://github.com/apache/superset/assets/60598000/b84c7547-6072-46c6-827d-85b86e2376c8";> There is an issue with setting up a custom width for the screenshot and then choosing the CSV option. The custom width param will still be sent to the backend and will generate a validation error if it is below 600px. That should be cleared. Also, not sure why the input for the custom width does not behave like a standard numeric input (up and down arrows on focus) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
