dpgaspar commented on code in PR #27154:
URL: https://github.com/apache/superset/pull/27154#discussion_r1497761976
##########
superset/cli/importexport.py:
##########
@@ -176,20 +177,21 @@ def import_datasources(path: str) -> None:
from superset.commands.dataset.importers.dispatcher import
ImportDatasetsCommand
from superset.commands.importers.v1.utils import get_contents_from_bundle
- if is_zipfile(path):
- with ZipFile(path) as bundle:
- contents = get_contents_from_bundle(bundle)
- else:
- with open(path) as file:
- contents = {path: file.read()}
- try:
- ImportDatasetsCommand(contents, overwrite=True).run()
- except Exception: # pylint: disable=broad-except
- logger.exception(
- "There was an error when importing the dataset(s), please check
the "
- "exception traceback in the log"
- )
- sys.exit(1)
+ with override_user(user=security_manager.find_user(username="admin")):
Review Comment:
it seems it would probably make sense to add a `username` option here and
leave `admin` as the default. @betodealmeida what to you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
