rtexelm commented on code in PR #26327:
URL: https://github.com/apache/superset/pull/26327#discussion_r1501087905
##########
superset-frontend/src/features/alerts/AlertReportModal.tsx:
##########
@@ -973,7 +981,8 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
notificationSettings.forEach(setting => {
if (!!setting.method && setting.recipients?.length) {
- hasInfo = true;
+ hasInfo =
+ setting.method === 'Email' ? !!setting.email_subject?.length : true;
Review Comment:
I think this is causing [the valid report unit
test](https://github.com/apache/superset/blob/d6dbb95cc45360ce24778811ab5a6d5f9a4198e6/superset-frontend/src/features/alerts/AlertReportModal.test.tsx#L255)
to fail. Might be causing your CI error. Do you need to push `email_subject`
to `settings` in `onNotificationAdd`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
