geido commented on code in PR #26602:
URL: https://github.com/apache/superset/pull/26602#discussion_r1504671762


##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/components/Legend.tsx:
##########
@@ -106,6 +106,7 @@ const Legend = ({
       <li key={k}>
         <a

Review Comment:
   Let's create a base component for links. When onClick / onDoubleClick are 
present we might assign the role button. Let's also account for the possibility 
to override the prop



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to