geido opened a new pull request, #27439:
URL: https://github.com/apache/superset/pull/27439

   ### SUMMARY
   After the changes in this PR https://github.com/apache/superset/pull/23762 
color inconsistency on refreshes was reintroduced.
   
   This PR does the following:
   
   - Color inconsistency on refreshes
   - Color inconsistency from chart in hidden tab to Explore
   - It improves a bit issues with color collisions by adding a usage tracker 
of the colors at the chart level
   - Deprecated AVOID_COLORS_COLLISION
   
   More work is required to manage color conflicts. In general, the color 
consistency implementation should be refactored.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N.A.
   
   ### TESTING INSTRUCTIONS
   1. Set a color scheme for a dashboard
   2. Refresh the dashboard
   3. Colors should not change
   4. Going from any chart in any tab to Explore, should carry the same colors 
forward
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to