mistercrunch commented on code in PR #27434:
URL: https://github.com/apache/superset/pull/27434#discussion_r1518454526


##########
docker-compose-non-dev.yml:
##########
@@ -23,6 +22,12 @@ x-superset-volumes:
   - ./docker:/app/docker
   - superset_home:/app/superset_home
 
+x-common-build: &common-build
+  context: .
+  target: dev
+  cache_from:
+    - apache/superset-cache:3.9-slim-bookworm

Review Comment:
   side note - one thing I noticed is cache doesn't always seem to hit when I 
think it should, I'm guessing that we have some limits / intelligent cache 
pruning that's preventing cache hit from always working .... cache hit rate is 
still pretty decent, and build times not awful either when missing the cache



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to