rusackas commented on code in PR #24449:
URL: https://github.com/apache/superset/pull/24449#discussion_r1521969620
##########
superset-frontend/src/dashboard/components/RefreshIntervalModal.tsx:
##########
@@ -111,17 +165,79 @@ class RefreshIntervalModal extends React.PureComponent<
modalTitle={t('Refresh interval')}
modalBody={
<div>
- <FormLabel>{t('Refresh frequency')}</FormLabel>
- <Select
- ariaLabel={t('Refresh interval')}
- options={refreshIntervalOptions.map(option => ({
- value: option[0],
- label: t(option[1]),
- }))}
- value={refreshFrequency}
- onChange={this.handleFrequencyChange}
- sortComparator={propertyComparator('value')}
- />
+ <div id="refresh_from_dropdown">
+ <FormLabel>
+ <b>{t('Refresh frequency')}</b>
+ </FormLabel>
+ <Select
+ ariaLabel={t('Refresh interval')}
+ options={this.createIntervalOptions(refreshIntervalOptions)}
+ value={refreshFrequency}
+ onChange={this.handleFrequencyChange}
+ sortComparator={propertyComparator('value')}
+ />
+ </div>
+ {custom_block && (
+ <div
+ style={{
+ display: 'flex',
+ marginTop: '15px',
+ }}
Review Comment:
We prefer not to use inline styles, or hard-coded pixel values. We prefer
using Emotion (kind of like Styled Components) and using the Theme's gridUnits.
There are some style guides available
[here](https://github.com/apache/superset/wiki/Emotion-Styling-Guidelines-and-Best-Practices).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
