zhaoyongjie commented on issue #27432:
URL: https://github.com/apache/superset/issues/27432#issuecomment-2003265622
> 2. Multiple time comparisons are supported in other chart types and are
frequently used. Could you describe how are they going to work.
The table and bar charts do not currently have time comparisons, which is
why we started here, but for Bar and Line which do have time comparisons, we
are looking to see how we can best improve the existing functionality and will
do a separate SIP on those chart types. If we find a better way to integrate
with the existing time filters, we may need to come back to this chart type and
update the filters to match. Another reason why this is being developed behind
a feature flag.
If you populate a temporal dimension, select a corresponding time filter,
and enable advanced analytics section, **the all viz except legacy nvd3
charts**, have readily supported time comparison, rolling, and resample. I've
opened a PR for demonstrate that Table chart with Advanced Analytics.
> New or Changed Public Interfaces
Changes in the UI are shown above. Because we also want to show the time
range in the UI, we will need to calculate that value separately. This may
require a new API endpoint. All new features are planned to be included behind
a feature flag.
The endpoint to fetch the time range could look like this:
get_relative_time_range_schema = {
"type": "object",
"properties": {"base_time_range": {"type": "string"}, "shift":
{"type": "string"}},
}
The original `/api/time_range` already support multiple time ranges request
at [PR](https://github.com/apache/superset/pull/27370), IMO, no need to
introduce a seprated endpoint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
