yousoph opened a new issue, #27617:
URL: https://github.com/apache/superset/issues/27617

   ### Motivation
   - Allow for more customization on bar and line charts when using the time 
comparison feature
   - Increase the flexibility of selecting a comparison date
   
   ### Proposed Changes
   Add the ability to do the following in Bar charts when using the Time Shift 
feature.
   
   **Time Shift Selection:** 
   
   - Select a custom time shift by selecting a start date from a date selector. 
This would allow for simpler comparison when looking at a holiday across 
multiple years. Black Friday in 2023 is on a different calendar date than Black 
Friday 2022 and isn’t currently easy to compare using the Time Shift.
   - Ability to easily shift the time based on the length of the original time 
range. For example, if the original chart time filter was 3 weeks and 1 day, 
the user could easily shift the time range to look at the 3 week and 1 day long 
period directly preceding the existing chart filter.
   - Display the comparison ranges in the control panel for the user to easily 
verify the comparison dates
   
   **Chart customizations:** 
   
   - Customize whether the comparison bar should appear to the left, right, or 
in chronological order vs the original bar
   - Customize the tooltip to include additional information such as the 
difference between the comparison period and the original or the % change 
between the two time periods
   - Display the comparison and original time ranges in the chart area for 
non-creator chart users to easily understand the comparison dates
   
   For Line Charts, we’d like to make all the above changes with the same 
patterns (other than customizing where the comparison bar appears). 
   
   ### New or Changed Public Interfaces
   
   See UI mockup here: 
   
![bar_comparison](https://github.com/apache/superset/assets/10627051/af23bfb1-4d43-4647-873d-72abaa00981a)
   
   
   ### New dependencies
   None
   
   ### Migration Plan and Compatibility
   In moving the controls to a new section in the Explore Control Panel, we’ll 
need to ensure that existing controls on previously created charts are 
retained. 
   
   ### Rejected Alternatives
   We considered whether these changes could require a new chart type or a new 
control for the time shift, but they had enough overlap with the current Time 
Shift functionality that it made the most sense to integrate it with existing 
charts and controls.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to