sfirke commented on PR #25540: URL: https://github.com/apache/superset/pull/25540#issuecomment-2015740612
> I suppose my only little question is this: does a user reliably know that a Report is a screenshot of a dashboard? Ah, I sent this PR because I was setting up a Report for a single chart and didn't like that it said "dashboard." I see now that when I set up a report for a dashboard, it uses this same modal, and in that case "dashboard" and "screenshot" are correct. Maybe that's where you're coming from? A report is not always a screenshot of a dashboard, it can be a screenshot or .csv of a single chart. Thus this fix which makes it agnostic as to which is being configured. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
