betodealmeida commented on code in PR #27631: URL: https://github.com/apache/superset/pull/27631#discussion_r1538276795
########## superset/db_engine_specs/hive.py: ########## @@ -547,7 +551,10 @@ def update_impersonation_config( @staticmethod def execute( # type: ignore - cursor, query: str, async_: bool = False + cursor, + query: str, + database_id: int, Review Comment: I had to add here because only Hive has the `async_` parameter, which gets unpacked from `**kwargs` in the base class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org