mistercrunch commented on code in PR #27641:
URL: https://github.com/apache/superset/pull/27641#discussion_r1538286575


##########
.github/actions/setup-backend/action.yml:
##########
@@ -24,6 +24,7 @@ runs:
         cache: ${{ inputs.cache }}
     - name: Install dependencies
       run: |
+        sudo apt-get update && sudo apt-get -y install libldap2-dev 
libsasl2-dev

Review Comment:
   I think it makes sense to bring python-related os dependencies in this 
`setup-backend` reusable action instead of within the `bashlib.sh` that I still 
don't understand how it gets discovered and executed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to