michael-s-molina commented on code in PR #27644:
URL: https://github.com/apache/superset/pull/27644#discussion_r1539052563
##########
superset/models/sql_lab.py:
##########
@@ -76,7 +77,7 @@ def sql_tables(self) -> list[Table]:
self.database.db_engine_spec.engine, # type: ignore
)
)
- except SupersetSecurityException:
+ except (SupersetSecurityException, TemplateError):
Review Comment:
Shouldn't we propagate the error here and let the caller handle it?
Returning empty for an error condition is not the same as returning empty when
the select actually does not have a table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
