betodealmeida commented on PR #27631: URL: https://github.com/apache/superset/pull/27631#issuecomment-2025818696
> Maybe a stupid question, but I think we should consider the implementation details. Why introduce a new table and a super complex foreign key topology? I believe this requirement is straightforward. We should store some tokens in the user table and keep the corresponding token in the user session. We can't store the tokens in the user table because it's a 1:n relationship. Storing in a table has the benefit that it's easy to make sure it's always encrypted, which is important since these are credentials, and we don't have to worry about session hijacking. I wouldn't call it a super complex key topology, it's two foreign keys to the user and the database tables, with cascade deletes to clean them up. > The metadata in Superset is extremely messy right now. Why do you guys always create new tables and create foreign keys for a super simple requirement? I don't know, why do people raise these discussions only after the SIP has been approved? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
