mistercrunch commented on code in PR #24112:
URL: https://github.com/apache/superset/pull/24112#discussion_r1544657216
##########
.github/actions/setup-backend/action.yml:
##########
@@ -22,6 +22,9 @@ runs:
with:
python-version: ${{ inputs.python-version }}
cache: ${{ inputs.cache }}
+ - name: apt-get deps
+ shell: bash
+ run: sudo apt-get install -y libldap2-dev libsasl2-dev
Review Comment:
redundant with the next step, probably a bad merge conflict (?)
##########
setup.py:
##########
@@ -208,13 +208,12 @@ def get_git_sha() -> str:
"starrocks": ["starrocks>=1.0.0"],
"doris": ["pydoris>=1.0.0, <2.0.0"],
},
- python_requires="~=3.9",
+ python_requires="~=3.10",
author="Apache Software Foundation",
author_email="[email protected]",
url="https://superset.apache.org/";,
download_url="https://www.apache.org/dist/superset/"; + version_string,
classifiers=[
- "Programming Language :: Python :: 3.9",
Review Comment:
ok so we want to keep this line for the time being
##########
scripts/build_docker.py:
##########
@@ -149,9 +149,9 @@ def get_docker_command(
build_target = "dev"
elif build_preset == "lean":
build_target = "lean"
- elif build_preset == "py310":
+ elif build_preset == "py311":
Review Comment:
optional, but we could add a `py39` preset here while we support 3.9 (until
we remove it in setup.py)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
