betodealmeida commented on PR #27858: URL: https://github.com/apache/superset/pull/27858#issuecomment-2033385594
> Now I'm wondering if `_extract_tables_from_sql` needs to run at all times or only if there are schema/tables restrictions in place. That's a good idea! Part of the problem today is that `_extract_tables_from_sql` is called by simply accessing the `.tables` property in the parsed query, we could make it more explicit so it's only called whenever really needed and not by mistake. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
