michael-s-molina commented on code in PR #27857:
URL: https://github.com/apache/superset/pull/27857#discussion_r1549612340
##########
superset/models/dashboard.py:
##########
@@ -250,6 +250,16 @@ def changed_by_name(self) -> str:
return ""
return str(self.changed_by)
+ @property
+ def created_by_name(self) -> str:
+ if not self.created_by:
+ return ""
+ return str(self.created_by)
+
+ @property
+ def owners_by_name(self) -> list[str]:
+ return [owner.get_full_name() for owner in self.owners]
Review Comment:
This looks like more of frontend code than a new model property. If you
check other instances of the Metadata component, this is being handled on the
frontend as we may have different representations of the possible values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
