john-bodley commented on code in PR #27904:
URL: https://github.com/apache/superset/pull/27904#discussion_r1552183316
##########
.github/workflows/superset-python-integrationtest.yml:
##########
@@ -6,8 +6,16 @@ on:
branches:
- "master"
- "[0-9].[0-9]"
+ paths:
+ - "superset/**"
+ - "requirements/**"
+ - "tests/integration_tests/**"
pull_request:
types: [synchronize, opened, reopened, ready_for_review]
+ paths:
+ - "superset/**"
Review Comment:
I wonder if we would need to include `.pre-commit-config.yaml` or would the
premise be that if `pre-commit` needed to touch any files the
`superset-python-misc.yml` workflow would fail. That would then force the user
run `tox -e pre-commit` locally which would then touch files in the
`superset/**` and `tests/**` paths?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
