jdruii opened a new pull request, #27933:
URL: https://github.com/apache/superset/pull/27933

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   - Added `philippines_regions.geojson` map using the regional ISO codes
   - Updates `philippines.geojson` by dividing Maguindanao province to 
Maguindanao del Norte and Maguindanao del Sur, as well as splintering off Davao 
Occidental from Davao del Sur
   - Cleans `philippines.geojson` by incorporating the inconsistently placed 
highly urbanized cities (which sometimes uses a pseudo-ISO code) into their 
respective geographical provinces. This is done to be more in line with how the 
Philippine Statistics Authority does it in their census.
   - Merges the 16 cities and 1 municipality within Metropolitan Manila under 
the regional ISO code `PH-00` since there is no provincial ISO for the cities 
within.
   
   References:
   - [ISO-3166-2:PH codes](https://en.wikipedia.org/wiki/ISO_3166-2:PH)
   - [2020 Philippine Census by the Philippine Statistics 
Authority](https://psa.gov.ph/content/highlights-philippine-population-2020-census-population-and-housing-2020-cph)
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
![ph_div](https://github.com/apache/superset/assets/146858759/977254cc-9d47-447e-9362-30b9ce8c8fe5)
   
![ph_prov_mm](https://github.com/apache/superset/assets/146858759/318d3094-c4b8-49a9-a8e4-8cc9e98eaace)
   
![ph_prov_luzon](https://github.com/apache/superset/assets/146858759/4f8286a5-9df7-4c2c-9fa4-a99323bed19d)
   
![ph_prov_visayas](https://github.com/apache/superset/assets/146858759/7c753934-fee4-4078-b69e-dc4b5bc7fd51)
   
![ph_prov_mindanao](https://github.com/apache/superset/assets/146858759/d55762ea-afc5-43a6-a7b9-5b304086984e)
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to