zhaoyongjie commented on code in PR #27934:
URL: https://github.com/apache/superset/pull/27934#discussion_r1555687199
##########
superset/common/query_context_processor.py:
##########
@@ -455,6 +455,13 @@ def processing_time_offsets( # pylint:
disable=too-many-locals,too-many-stateme
for metric in metric_names
}
+ # When the original query has limit or offset we wont apply those
+ # to the subquery so we prevent data inconsistency due to missing
records
+ # in the dataframes when performing the join
+ if query_object.row_limit or query_object.row_offset:
+ query_object_clone_dct["row_limit"] = None
Review Comment:
We should apply `row_limit` in config.py, in order to avoid a heavy query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
