mistercrunch commented on code in PR #27953:
URL: https://github.com/apache/superset/pull/27953#discussion_r1561291952
##########
.github/workflows/docker.yml:
##########
@@ -21,7 +21,7 @@ jobs:
steps:
- id: set_matrix
run: |
- MATRIX_CONFIG=$(if [ "${{ github.event_name }}" == "pull_request" ];
then echo '["ci"]'; else echo '["dev", "lean", "py310", "websocket",
"dockerize"]'; fi)
+ MATRIX_CONFIG=$(if [ "${{ github.event_name }}" == "pull_request" ];
then echo '["dev"]'; else echo '["dev", "lean", "py310", "websocket",
"dockerize"]'; fi)
Review Comment:
this is a bit cryptic, but the short story is we built only the `ci` layer
in PRs (and a wider list on `master` push events), and I decided that building
`dev` makes much more sense. I thought `ci` was all-encompassing when I first
set this matrix, but turns out it's just a small layer on top of lean. Testing
`dev` captures the bulk of the dockerfile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
