rusackas commented on code in PR #27849: URL: https://github.com/apache/superset/pull/27849#discussion_r1561501550
########## superset/config.py: ########## @@ -1328,6 +1328,8 @@ def EMAIL_HEADER_MUTATOR( # pylint: disable=invalid-name,unused-argument # Slack API token for the superset reports, either string or callable SLACK_API_TOKEN: Callable[[], str] | str | None = None SLACK_PROXY = None +# Whether Superset should use Slack avatars for users +SLACK_ENABLE_AVATARS = True Review Comment: At one point we discussed and _might have completed_ moving all boolean configs to Feature Flags. If that's going to be a policy (which I don't think has _official_ consensus) then this should be too. CC @eschutho and @michael-s-molina in case they remember differently. I'm just a fan of consistency, in any case ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
