genzgd commented on issue #28014: URL: https://github.com/apache/superset/issues/28014#issuecomment-2053693424
@ivkhokhlachev -- I think it makes sense to remove the toDateTime as a wrapper for any functions that can take String arguments, but we'd have to validate that against older versions of ClickHouse. That particular code is at least 5 years old and I suspect the behavior of those functions has changed. If the String conversion has been available for 2 or 3 years, we can remove that wrapper. Something like TIME_GRAIN_OVERRIDE_EXPRESSIONS might work, but it's not an area of Superset functionality I know much about. (I work for ClickHouse Inc. on, among other things, the `clickhouse-connect` Python driver). @villebro or other core Superset devs might have an opinion, but I wouldn't be comfortable implementing any significant outside of the ClickHouseEngineSpec. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
