mistercrunch commented on PR #28042: URL: https://github.com/apache/superset/pull/28042#issuecomment-2059980013
> Did/should the bot catch this bump? Not sure yet how to tell (though I admit I'm still going through GH notifications). Seems like this is could be an important bump, and it passes all the tests, so I'm not sure how to tell if this PR is a bad idea. Would one need to pull it an pip-compile-multi? This bump does effectively nothing as is, it augments the boundaries but not the pinned dependency. I was thinking I'd align with what @michael-s-molina said about batching updates in time windows close to releases. About whether this bump is important, there's probably a good reason why this upper boundary was set in the first place. I'd like to start enforcing comments associated with all upper boundaries. Meaning if you set `sqlparse<0.5.0` you leave a comment above saying something like (just an example) "# tested with 0.5.0 and it drops support for python3.9 which we're planning to deprecate in superset 5.0.0". But stepping back I don't think this bump is more important than the dozen others stuck in the pipeline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
