Woellchen opened a new pull request, #28110: URL: https://github.com/apache/superset/pull/28110
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR adds user impersonation support for the StarRocks database by leveraging the native `EXECUTE AS {user} WITH NO REVERT` user management query. ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. If necessary create a separate user on your StarRocks DB and your Superset instance. The names must match and it should be different from the user that is used for the StarRocks connection itself 2. Enable the user impersonation feature in the security settings of your StarRocks database 3. Log in to Superset with your testing user 4. Execute `SELECT CURRENT_USER();` and see that it shows your current Superset user 5. Disable user impersonation feature again 6. Execute `SELECT CURRENT_USER();` again and see that it changed back to the user of the StarRocks connection ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
