eschutho opened a new pull request, #28132:
URL: https://github.com/apache/superset/pull/28132

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   Found a small bug where the render operator function was being passed in 
instead of executed and so the operator was undefined. I just renamed the 
variable so that it would sound more like a method to make it easier to catch 
in the future. Also added some tests. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before: 
   
![image](https://github.com/apache/superset/assets/5186919/6814bb9d-e4ac-4abb-bf83-34934f70cad9)
   
   After: 
   <img width="737" alt="Screenshot 2024-04-18 at 2 30 39 PM" 
src="https://github.com/apache/superset/assets/5186919/a801da92-059b-4548-a7c0-bbf3682d1538";>
   
   
   ### TESTING INSTRUCTIONS
   Add a color condition to a column on the table viz
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to