mistercrunch commented on issue #26395: URL: https://github.com/apache/superset/issues/26395#issuecomment-2070642836
Hey, loving the designs here! I wanted to bring up the topic of caching and autocomplete and make sure they're somewhat in-scope for this SIP. Around caching, the sqlalchemy `get_table_names` dialect method can be really slow at times on some database engine, and creates strains on some systems, and I think we currently have some caching in place around that method/endpoint. Maybe we simply need a force-refresh that's more explicit than say collapsing+re-extending the table name list. As with charts, it's great if we can surface cache metadata (is this served from cache? when was the snapshot taken) and expose a clear way to force-refresh. Both speed and freshness matter here. About autocomplete, currently the scope for autocomplete in the editor is related to what's in the left panel, meaning by we only auto-complete table names within the active schemas, and column names for the tables added in that accumulator section. Here we probably want to follow the same pattern where autocomplete would be limited to what's been retrieved by the frontend, as opposed to say trying to include everything. ---- Another topic related to this left panel - and maybe out of scope for this SIP - is the idea of allowing users to search/find tables by names, especially when not knowing the schema it might be in. Currently if you don't know the name of the schema and/or the full name of the table, you're at a loss. While this is probably out of scope for the SIP, it's good to think how we might allow users to search for tables across schemas in the future, maybe with a search box at the top of the left panel, and maybe leveraging some sort of cache (?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
