hughhhh commented on code in PR #28203:
URL: https://github.com/apache/superset/pull/28203#discussion_r1578516962
##########
superset/common/query_object.py:
##########
@@ -257,7 +257,7 @@ def _move_deprecated_extra_fields(self, kwargs: dict[str,
Any]) -> None:
@property
def metric_names(self) -> list[str]:
"""Return metrics names (labels), coerce adhoc metrics to strings."""
- return get_metric_names(self.metrics or [])
+ return get_metric_names(self.metrics or [],
self.datasource.verbose_map)
Review Comment:
can we add a small unit test to verify that metric_names will always return
properly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
