mistercrunch commented on code in PR #28280:
URL: https://github.com/apache/superset/pull/28280#discussion_r1588123506
##########
.github/workflows/superset-frontend.yml:
##########
@@ -5,7 +5,7 @@ on:
branches:
- "master"
- "[0-9].[0-9]"
- pull_request:
+ pull_request_target:
Review Comment:
That's right, and the person calling from the fork can't change the workflow
itself (the one from the main branch runs), but if that workflow calls say a
script (or evolves into calling one down the line), then they could extract the
env vars and/or secrets specified on the main branch for that action. We should
review our `pull_request_target ` and put them in a special place where we have
extra caution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
