hainenber commented on code in PR #28343:
URL: https://github.com/apache/superset/pull/28343#discussion_r1591296839
##########
.github/workflows/dependency-review.yml:
##########
@@ -23,22 +23,13 @@ jobs:
# compatible/incompatible licenses addressed here:
https://www.apache.org/legal/resolved.html
# find SPDX identifiers here: https://spdx.org/licenses/
deny-licenses: MS-LPL, BUSL-1.1, QPL-1.0, Sleepycat, SSPL-1.0,
CPOL-1.02, AGPL-3.0, GPL-1.0+, BSD-4-Clause-UC, NPL-1.0, NPL-1.1, JSON
- allow-dependencies-licenses:
- # adding an exception for an ambigious license on store2, which
has been resolved in
- # the latest version. It's MIT:
https://github.com/nbubna/store/blob/master/LICENSE-MIT
- - 'pkg:npm/[email protected]'
- # adding exception for all applitools modules (eyes-cypress and
its dependencies),
- # which has an explicit OSS license approved by ASF
- # license: https://applitools.com/legal/open-source-terms-of-use/
- - 'pkg:npm/applitools/core'
- - 'pkg:npm/applitools/core-base'
- - 'pkg:npm/applitools/css-tree'
- - 'pkg:npm/applitools/ec-client'
- - 'pkg:npm/applitools/eg-socks5-proxy-server'
- - 'pkg:npm/applitools/eyes'
- - 'pkg:npm/applitools/eyes-cypress'
- - 'pkg:npm/applitools/nml-client'
- - 'pkg:npm/applitools/tunnel-client'
- - 'pkg:npm/applitools/utils'
- # Selecting BSD-3-Clause licensing terms for node-forge to ensure
compatibility with Apache
- - 'pkg:npm/[email protected]'
+ # pkg:npm/[email protected]
+ # adding an exception for an ambigious license on store2, which
has been resolved in
+ # the latest version. It's MIT:
https://github.com/nbubna/store/blob/master/LICENSE-MIT
+ # pkg:npm/applitools/*
+ # adding exception for all applitools modules (eyes-cypress and
its dependencies),
+ # which has an explicit OSS license approved by ASF
+ # license: https://applitools.com/legal/open-source-terms-of-use/
+ # pkg:npm/[email protected]
+ # selecting BSD-3-Clause licensing terms for node-forge to ensure
compatibility with Apache
+ allow-dependencies-licenses: pkg:npm/[email protected],
pkg:npm/applitools/core, pkg:npm/applitools/core-base,
pkg:npm/applitools/css-tree, pkg:npm/applitools/ec-client,
pkg:npm/applitools/eg-socks5-proxy-server, pkg:npm/applitools/eyes,
pkg:npm/applitools/eyes-cypress, pkg:npm/applitools/nml-client,
pkg:npm/applitools/tunnel-client, pkg:npm/applitools/utils,
pkg:npm/[email protected]
Review Comment:
The GH action only accepts the input arg as single line. Maybe it will get
fixed in the future version but for now, it's the only way proceeding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
