mistercrunch opened a new pull request, #28360: URL: https://github.com/apache/superset/pull/28360
### SUMMARY I was using SQL_QUERY_MUTATOR for something specific for a customer, and had to double-check whether what's done in `config.SQL_QUERY_MUTATOR` does or doesn't affect the cache key. After checking I thought I would clarify this as a comment where it's defined. Knowing this, it could be good to allow this configuration to affect the cache key as there are use cases where you may want to mutate the SQL with say adding a specific predicate, and make sure that that predicate is captured in the cache key, but that's beyond the scope of this PR. It didn't seem trivial (nor super difficult) to add this feature, and it seemed it would require 1. changing the function signature to allow returning not only the SQL, but something to add to the cache key and 2. carrying that through the stack and onto the place where the cache key is defined. From my understanding SQL_QUERY_MUTATOR is often use to add metadata so around the query in the form of comments, for instance passing the username of who's running the SQL, so that its captured in the database logs. For these use cases there's really no need for altering the cache key. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
