michael-s-molina opened a new pull request, #28368: URL: https://github.com/apache/superset/pull/28368
### SUMMARY Fix percentages shown in tooltips of ECharts plugins that contain time offsets and contribution mode enabled. The ECharts version does not distinguish series and time shifts when calculating the contribution percentages as the legacy version does. Instead of showing something like series A 50%, series B 50%, series A (a year ago) 50%, series B (a year ago) 50%, it shows all series with 25%. With this fix, the contribution of time shifts are calculated independently. This is another pre-requisite to unblock timeseries chart migrations. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <img width="1030" alt="Screenshot 2024-05-03 at 10 05 57" src="https://github.com/apache/superset/assets/70410625/6b58d9e5-b2c2-4125-846d-964ecc19a85f";> <img width="1044" alt="Screenshot 2024-05-07 at 10 25 03" src="https://github.com/apache/superset/assets/70410625/fbd5d5de-91c7-42f3-96d8-e166b34cda84";> ### TESTING INSTRUCTIONS Check that time shift contributions are calculated independently. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
