michael-s-molina commented on code in PR #27950:
URL: https://github.com/apache/superset/pull/27950#discussion_r1592527402
##########
superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/transformProps.ts:
##########
@@ -119,10 +123,11 @@ export default function transformProps(
let [min, max] = (valueBounds || []).map(parseAxisBound);
if (min === undefined) {
- min = minBy(data, row => row[colorColumn])?.[colorColumn] as number;
+ min = (minBy(data, row => row[colorColumn])?.[colorColumn] as number) || 0;
}
if (max === undefined) {
- max = maxBy(data, row => row[colorColumn])?.[colorColumn] as number;
+ max =
+ (maxBy(data, row => row[colorColumn])?.[colorColumn] as number) || 200;
Review Comment:
This is coming from the [default
values](https://echarts.apache.org/en/option.html#visualMap-continuous.max) of
ECharts. I added a constant to better describe the value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
