michael-s-molina commented on code in PR #28387:
URL: https://github.com/apache/superset/pull/28387#discussion_r1594322812
##########
superset/views/css_templates.py:
##########
@@ -54,8 +48,15 @@ def list(self) -> FlaskResponse:
class CssTemplateAsyncModelView( # pylint: disable=too-many-ancestors
CssTemplateModelView
):
- include_route_methods = {RouteMethod.API_READ}
+ include_route_methods = RouteMethod.API_READ
class_permission_name = "CssTemplate"
method_permission_name = MODEL_VIEW_RW_METHOD_PERMISSION_MAP
list_columns = ["template_name", "css"]
+
+ @expose_api(name="read", url="/api/read", methods=["GET"])
+ @has_access_api
+ @permission_name("list")
+ @deprecated(eol_version="5.0.0")
Review Comment:
@dpgaspar We discussed this during the release meeting and we agreed to
remove these legacy endpoints during a breaking window even if they are not
under `v1`. That's what we did in the past and we just want to be mindful that
someone out there might still be using the endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
