Vitor-Avila commented on code in PR #28393:
URL: https://github.com/apache/superset/pull/28393#discussion_r1594780215
##########
superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/CommonParameters.tsx:
##########
@@ -116,6 +116,69 @@ export const databaseField = ({
helpText={t('Copy the name of the database you are trying to connect to.')}
/>
);
+export const defaultCatalogField = ({
+ required,
+ changeMethods,
+ getValidation,
+ validationErrors,
+ db,
+}: FieldPropTypes) => (
+ <ValidatedInput
+ id="default_catalog"
+ name="default_catalog"
+ required={required}
+ value={db?.parameters?.default_catalog}
+ validationMethods={{ onBlur: getValidation }}
+ errorMessage={validationErrors?.default_catalog}
+ placeholder={t('e.g. hive_metastore')}
+ label={t('Default Catalog')}
+ onChange={changeMethods.onParametersChange}
+ helpText={t('The default catalog that should be used for the connection.')}
+ />
+);
+export const defaultSchemaField = ({
+ required,
+ changeMethods,
+ getValidation,
+ validationErrors,
+ db,
+}: FieldPropTypes) => (
+ <ValidatedInput
+ id="default_schema"
+ name="default_schema"
+ required={required}
+ value={db?.parameters?.default_schema}
+ validationMethods={{ onBlur: getValidation }}
+ errorMessage={validationErrors?.default_schema}
+ placeholder={t('e.g. default')}
+ label={t('Default Schema')}
+ onChange={changeMethods.onParametersChange}
+ helpText={t('The default schema that should be used for the connection.')}
+ />
+);
+export const httpPathField = ({
Review Comment:
Had to create a new field for **HTTP Path** as the existing one included
logic to retrieve/insert information in the `engine_params`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
