john-bodley opened a new pull request, #28422: URL: https://github.com/apache/superset/pull/28422
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY I realize it's generally perceived as poor form to change an existing migration, however per [here](https://github.com/apache/superset/blob/f29e1e4c29a46f7d607cfa59adb8bb21d107091c/superset/migrations/versions/2019-05-06_14-30_afc69274c25a_alter_sql_column_data_type_in_query_mysql_table.py#L36-L46) the `query. executed_sql` and `query. select_sql` were previously defined as type `LONGTEXT` and thus: 1. Downsizing these columns to `MEDIUMTEXT` could result in data loss. 2. Altering the `query` table unnecessarily can be rather expensive given the size of the table. This PR remove mutating these columns unnecessarily. It also adds a new migration to resize the columns back to `LONGTEXT` if the previous migration has already been run. If not, the migration is a no-op. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS Tested the migration using a MySQL metadata database. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [x] Migration is atomic, supports rollback & is backwards-compatible - [x] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
