sfirke commented on code in PR #28221: URL: https://github.com/apache/superset/pull/28221#discussion_r1598804263
########## docs/docs/installation/pypi.mdx: ########## @@ -100,24 +98,18 @@ We highly recommend installing Superset inside of a virtual environment. Python pip install virtualenv ``` -You can create and activate a virtual environment using: - +First create a directory for Superset: ``` -# virtualenv is shipped in Python 3.6+ as venv instead of pyvenv. -# See https://docs.python.org/3.6/library/venv.html -python3 -m venv venv -. venv/bin/activate +mkdir superset ``` -Or with pyenv-virtualenv: Review Comment: @john-bodley circling back to this -- are you good with my changes or is there another committer you think could weigh in? Or if nothing else I can revert these parts, I'd rather just get the bulk of this merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
