john-bodley commented on code in PR #28492:
URL: https://github.com/apache/superset/pull/28492#discussion_r1600410102
##########
superset/views/database/views.py:
##########
@@ -92,34 +98,6 @@ class DatabaseView(DatabaseMixin, SupersetModelView,
DeleteMixin, YamlExportMixi
yaml_dict_key = "databases"
- @expose("/show/<pk>", methods=["GET"])
- @has_access
- @deprecated(eol_version="5.0.0")
- def show(self, pk: int) -> FlaskResponse:
- """Show database"""
- return super().show(pk)
-
- @expose("/add", methods=["GET", "POST"])
Review Comment:
Is this (as well as `/edit/<pk>` and `/delete/<pk>`) deprecated or actually
removed? I couldn't find their alternative form (unlike `/show/<pk>`) in your
PR. The reason I'm asking is removing a legacy endpoint would be considered a
breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
