justinpark opened a new pull request, #28507: URL: https://github.com/apache/superset/pull/28507
### SUMMARY The Tab component was inadvertently appending the item into its sibling. This commit fixes the #28417 by adding correct dropToChild logic for Tab component, ensuring that items are placed where they should be. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF - Before https://github.com/apache/superset/assets/1392866/22fc70dc-1a17-4d91-8a4b-ce8e6d1b3419 - After https://github.com/apache/superset/assets/1392866/952a0322-cb06-4358-81b3-aa9fba720397 ### TESTING INSTRUCTIONS - Drop a chart component into a Tab - The drop component should be place underneath the tab ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
